On Fri, Apr 14, 2023 at 09:31:03AM +0200, Maxime Soulé wrote: [...] > > Let me know if you have any additional comments and what's next. > > Looks good to me, just run "make indent" to conform to the repo style (you > will see session.c is badly formatted, do not include its changes in your > commits). Whitespace changes from astyle integrated and pushed.
> The next step is an approval of a committer like Matthew Fuller or > Rhialto/Olaf. How does that work? Would filing a GitHub PR be acceptable? Or something on Launchpad? Or send an email with the patches? What about documentation changes for the new macros? Is that something I do as part of the change or other committers take care of? Any expectation for writing tests? > ++ > > Max. Quentin
