On Mon 25 Aug 2025 at 10:23:40 +0200, Paul Schutte wrote:
> The lack of any other strategy. The only way to use HandleConfigureRequest
> is to use the global Event, it does not take parameters.
> The other option would be to basically duplicate HandleConfigureRequest
> just so you can pass it an Event structure.

That sounds like it would be useful to change HandleConfigureRequest()
from using the global Event to taking a parameter, and if really needed
to add a convenience function that calls the new version with the global
Event.

HandleConfigureRequest() already does "XConfigureRequestEvent *cre =
&Event.xconfigurerequest" at the top, and uses cre for *most* (but now
all) cases, so introducing a parameter for this seems like it should not
be too disruptive. Mainly it means to understand this comment:

        /*
         * Event.xany.window is Event.xconfigurerequest.parent, so Tmp_win will
         * be wrong
         */
        Event.xany.window = cre->window;    /* mash parent field */
        Tmp_win = GetTwmWindow(cre->window);

Hopefully it calls no functions that also use the global Event directly;
that would need to be checked.

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert                            <rhialto/at/falu.nl>
\X/ There is no AI. There is just someone else's work.           --I. Rose

Attachment: signature.asc
Description: PGP signature

Reply via email to