Hi Dan,
I so that in parallel to posting the patch, you committed it to the cvs.
So, I updated my working area from the cvs, and look and behold- the
WorkSpaceManager colors came back! Thank a lot,
Zvi.
[EMAIL PROTECTED] wrote:
>Hi again
>
>I took a closer look at the initiation of the workspacemanager yesterday
>and found the problem. The split of the workspacemanager config I tried in
>alpha5 is not necessary.
>
>Try applying the diff below:
>
>--- cut here ---
>Index: ctwm.c
>===================================================================
>RCS file: /orgs/lp/free/cvs/X/ctwm/ctwm.c,v
>retrieving revision 1.7
>diff -r1.7 ctwm.c
>730c730
>< ConfigureWorkSpaceManager1 ();
>---
>
>
>> ConfigureWorkSpaceManager ();
>>
>>
>747,748d746
><
>< ConfigureWorkSpaceManager2 ();
>Index: parse.c
>===================================================================
>RCS file: /orgs/lp/free/cvs/X/ctwm/parse.c,v
>retrieving revision 1.5
>diff -r1.5 parse.c
>1588a1589,1590
>
>
>> virtualScreen *vs;
>>
>>
>>
>1671a1674,1677
>
>
>> for (vs = Scr->vScreenList; vs != NULL; vs = vs->next) {
>> vs->wsw->vspace = Scr->WMgrVertButtonIndent;
>> }
>> Scr->workSpaceMgr.occupyWindow->vspace =
>>
>>
>Scr->WMgrVertButtonIndent;
>1676a1683,1686
>
>
>> for (vs = Scr->vScreenList; vs != NULL; vs = vs->next) {
>> vs->wsw->hspace = Scr->WMgrHorizButtonIndent;
>> }
>> Scr->workSpaceMgr.occupyWindow->hspace =
>>
>>
>Scr->WMgrHorizButtonIndent;
>Index: workmgr.c
>===================================================================
>RCS file: /orgs/lp/free/cvs/X/ctwm/workmgr.c,v
>retrieving revision 1.5
>diff -r1.5 workmgr.c
>151,154c151
>< /* dl: I split ConfigureWSM into two functions to make vscreens work
>properly
>< */
><
>< ConfigureWorkSpaceManager1 () {
>---
>
>
>>ConfigureWorkSpaceManager () {
>>
>>
>162,168c159
>< }
>< }
><
>< ConfigureWorkSpaceManager2 () {
>< virtualScreen *vs;
>< for (vs = Scr->vScreenList; vs != NULL; vs = vs->next) {
>< vs->wsw->curColors.back = Scr->Black;
>---
>
>
>> vs->wsw->curColors.back = Scr->Black;
>>
>>
>170c161,162
>< vs->wsw->state = Scr->workSpaceMgr.initialstate; /* =
>BUTTONSSTATE */
>---
>
>
>> vs->wsw->defColors.back = Scr->White;
>> vs->wsw->defColors.fore = Scr->Black;
>>
>>
>174,175c166
>< vs->wsw->defColors.back = Scr->White;
>< vs->wsw->defColors.fore = Scr->Black;
>---
>
>
>> vs->wsw->state = Scr->workSpaceMgr.initialstate; /* BUTTONSSTATE
>>
>>
>*/
>178,180c169
>< }
>< Scr->workSpaceMgr.occupyWindow->vspace = Scr->WMgrVertButtonIndent;
>< Scr->workSpaceMgr.occupyWindow->hspace = Scr->WMgrHorizButtonIndent;
>---
>
>
>> }
>>
>>
>182d170
><
>
>--- end cut ---
>
>Best Regards,
>
>//\\ /"\
> dL - Dan Lilliehorn \ / ASCII ribbon campaign
> http://www.dL.nu/ X against HTML email
> [EMAIL PROTECTED] / \
>
>On Tue, 15 Jun 2004, Zvi Har'El wrote:
>
>
>
>>Dear Dan,
>>
>>Thank you for your reply. My WorkSpaces setup is
>>
>>WorkSpaces { "F1" "F2" "F3" "F4" "F5" "F6" }
>>
>>I.e. I just name them, no color information.
>>
>>Best,
>>
>>Zvi.
>>
>>On Tue, 15 Jun 2004 08:47:44 +0200, [EMAIL PROTECTED] wrote about "Re:
>>[repository.lp.se #20] 3.7-alpha4 & MapWindowCurrentWorkSpace":
>>
>>
>>>Hi
>>>
>>>What does your WorkSpaces{}-list look like? If you set something else
>>>there, parameter 2-4 in MapWindow*Workspace will have no effect.
>>>
>>>In the example below, the background/foreground colors for "1" will be
>>>black/white and for "2" blue/yellow. Regardless of what you put as
>>>parameter 2&3 in MapWindow*Workspace.
>>>
>>>MapWindowCurrentWorkSpace # appearance of current WS
>>>{"black" "red" "red"}
>>>#border_color [background] [foreground] [bitmap]
>>>
>>>MapWindowDefaultWorkSpace # appearance of default WS
>>>{"gray40" "green" "green"}
>>>#border_color [background] [foreground] [bitmap] }
>>>
>>>WorkSpaces
>>>{
>>># N MC MTC BC FC
>>> "1" { "black" "white" "black" "white"}
>>> "2" { "blue" "yellow" "blue" "yellow"}
>>>}
>>>
>>>Best Regards
>>>
>>>//\\ /"\
>>> dL - Dan Lilliehorn \ / ASCII ribbon campaign
>>> http://www.dL.nu/ X against HTML email
>>> [EMAIL PROTECTED] / \
>>>
>>>On Fri, 11 Jun 2004, Zvi Har'El wrote:
>>>
>>>
>>>
>>>>It doesn't seem to work in Alpha 5. I have in my .ctwmrc
>>>>
>>>>
>>>>MapWindowDefaultWorkspace { "lightblue" "lightblue" "white" }
>>>>MapWindowCurrentWorkspace { "black" "lightblue" "white" }
>>>>
>>>>And while the first parameter works (border color), the other two
>>>>(forground, background) colors seem to have no effect. I am using
>>>>ctwm-3.7 alph5 on RedHat 9 system, with I18N enabled:
>>>>
>>>>~$ ctwm -info
>>>>Twm version: MIT X Consortium, R6, ctwm 3.7 + I18N Patch
>>>>Compile time options : XPM USEM4 I18N
>>>>~$ ctwm -version
>>>>3.7-alpha5
>>>>~$ uname -a
>>>>Linux bambi 2.4.20-18.9 #1 Thu May 29 07:08:16 EDT 2003 i686 i686 i386
>>>>GNU/Linux
>>>>
>>>>
>>>>Dan Lilliehorn via RT wrote:
>>>>
>>>>
>>>>
>>>>>Should be resolved in ctwm-3_7-alpha5 by splitting the init of virtual
>>>>>screens.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>[levitte - Mon Mar 03 03:33:45 2003]:
>>>>>>
>>>>>>In message <[EMAIL PROTECTED]> on Mon, 03 Mar 2003
>>>>>>02:25:07 +0100, "\"[EMAIL PROTECTED]" via
>>>>>>RT" <[EMAIL PROTECTED]> said:
>>>>>>
>>>>>>ctwm-bugs> MapWindowCurrentWorkSpace doesn't appear to have any affect
>>>>>>on the
>>>>>>ctwm-bugs> display of the workspace manager. Worked as advertised
>>>>>>with 3.6.
>>>>>>
>>>>>>Same report as ticket #17, so I merged them together...
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>--
>>>>Dr. Zvi Har'El mailto:[EMAIL PROTECTED] Department of Mathematics
>>>>tel:+972-54-4227607 icq:179294841 Technion - Israel Institute of Technology
>>>>fax:+972-4-8293388 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
>>>>"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
>>>>
>>>>
>>>>
>>>>
>>>>
>>--
>>Dr. Zvi Har'El mailto:[EMAIL PROTECTED] Department of Mathematics
>>tel:+972-54-4227607 icq:179294841 Technion - Israel Institute of Technology
>>fax:+972-4-8293388 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
>>"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
>> Tuesday, 26 Sivan 5764, 15 June 2004, 10:00AM
>>
>>
>>
--
Dr. Zvi Har'El mailto:[EMAIL PROTECTED] Department of Mathematics
tel:+972-54-4227607 icq:179294841 Technion - Israel Institute of Technology
fax:+972-4-8293388 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
