On Mon, Oct 29, 2007 at 08:45:04PM -0500 I heard the voice of
Matthew D. Fuller, and lo! it spake thus:
> 
> See attached patch.

Well, hearing no objections, I've reread the patch enough to convince
myself that it's right (or at least, where wrong, the old code was at
least as wrong).  So, this is pushed.  At least one actual bug (var
used before defined) is fixed, as well as some potential latent ones
on platforms where sizeof(int) != sizeof(long), and some general
warning-petting beyond that.  The most likely source of problems will
come from lex/yacc output code.

There remain a large hunk of warnings when strict-aliasing is enabled,
mostly around X{Find,Save}Context().  A large number can also be found
with -Wsign-compare that I didn't have the heart to get into.  Maybe
next round...


-- 
Matthew Fuller     (MF4839)   |  [EMAIL PROTECTED]
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.

Reply via email to