Allright, Rhialto, I looked into it, I'm pretty convinced that these
comments out bits were just for debugging stuff.
Sorry about that.
Here is a patch that brings back these, and the SaveWorkspaceFeature
still works fine on my box.
Sorry about the oversight.
============================================================
--- workmgr.c a11f12938a57d0f92468beda684b3f85dfdd1d66
+++ workmgr.c 87e4ef824168619de5555092d58c71fe9cbf9b26
@@ -497,12 +497,10 @@ void GotoWorkSpace (virtualScreen *vs, W
break;
}
}
- } /*else
- if (twmWin->hasfocusvisible) {
+ } else if (twmWin->hasfocusvisible) {
focuswindow = twmWin;
SetFocusVisualAttributes (focuswindow, False);
- }
- */
+ }
}
}
/* Move to the end of the twmWin list */
@@ -541,11 +539,9 @@ void GotoWorkSpace (virtualScreen *vs, W
}
}
CurrentIconManagerEntry (wl);
- /*
if (focuswindow) {
SetFocusVisualAttributes (focuswindow, True);
}
- */
vs->wsw->currentwspc = newws;
if (Scr->ReverseCurrentWorkspace && vs->wsw->state == MAPSTATE) {
MapSubwindow *msw = vs->wsw->mswl [oldws->number];
@@ -639,7 +635,7 @@ void GotoWorkSpace (virtualScreen *vs, W
/* /\* keep track of the order of the workspaces across restarts
*\/ */
/* CtwmSetVScreenMap(dpy, Scr->Root, Scr->vScreenList); */
-/* XSync (dpy, 0); */
+ XSync (dpy, 0);
if (Scr->ClickToFocus || Scr->SloppyFocus) set_last_window (newws);
MaybeAnimate = True;
}
On Sun, 2 Dec 2007 16:29:24 +0100, "Rhialto" <[EMAIL PROTECTED]> said:
> On Fri 30 Nov 2007 at 12:47:17 -0800, Martin Blais wrote:
> > This patch introduces a new feature called "SaveWorkspaceFocus", which
> > when enabled, makes ctwm remember which window has the focus within
> > each virtual workspace. As you switch workspaces, the cursor is
> > automatically warped to the window previous in focus in the workspace.
> > This significantly reduces the amount of mouse use.
>
> That sounds very useful! A great idea. However, the patch seems to have
> some unrelated changes? One thing I notice is the unconditional removal
> of stuff related to "hasfocusvisible" (not that I'm sure what it is
> doing, though, without doing some more research), and the other witn
> "keep track of the order of the workspaces across restarts". Now if
> those things are broken or useless in general I don't mind having them
> removed, but if they are just interfering somehow with this
> functionality, it should depend on the config file setting, I think.
>
> Cheers,
> -Olaf.
> --
> ___ Olaf 'Rhialto' Seibert -- You author it, and I'll reader it.
> \X/ rhialto/at/xs4all.nl -- Cetero censeo "authored" delendum
> esse.
