In message <[email protected]> on Mon, 11 Feb 2013 23:55:32 +0100, 
Rhialto <[email protected]> said:

rhialto> Shall I clean up the commented-out code from below and commit, or 
should
rhialto> I not bother?

If it's debugging prints, I'd say remove them or surround them with
#ifdef DEBUG..#endif.  Also, I'd very much like if debug messages were
clearly marked as such, take this as an example (from add_window.c):

  #ifdef DEBUG
              fprintf(stderr, "DEBUG[DontMoveOff]: availableY: %d\n",
                      available);
  #endif

For other lines, if you feel safe removing them, please do.  If you're
uncertain (for example if there's a line you've commented away but
aren't entirely sure that's the right thing to do), please leave it
there.

Also, I'd much rather have comments in traditional C format (you know,
/* ... */) rather than C++ format (//...).  There's a risk of hitting
older C compilers that will break on the // variant.

Cheers,
Richard

-- 
Richard Levitte                         [email protected]
                                        http://richard.levitte.org/

"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish

Reply via email to