2009/6/1, Igor Novoseltsev wrote:

> Please review the patch.

In no particular order...

strerror_r() on VxWorks might have two arguments but the return type
is not the error converted to a string. It is something like OK or
ERROR. You should probably write an VxWorks wrapper for that function.

I have not bothered to look up open() with three args but there could
happen something similar as above. You'll know better than me.

config-vxworks.h seems to be manually adjusted from a config.h file
generated cross-compiling or something with curl's configure version
prior to 7.19.5

Don't include header files in config-vxworks.h If you badly need to do
something similar generate another file like 'setup-vxworks.h' which
will include those header files, and have 'setup-vxworks.h' included
from setup.h close to where setup-os400.h is currently included.

In Makefile.vxworks why do you copy config-vxworks.h as config.h?
There should be no need at all this is a non-configure build.

-- 
-=[Yang]=-

Reply via email to