Kamil Dudka wrote:
On Tuesday 06 of October 2009 20:15:48 Rob Crittenden wrote:I finally got some time to review the recent Guenter's patch for lib/nss.c. It looks good to me and it works fine with my test-suite [1]. I've just built it for rawhide.What do you mean?http://curl.haxx.se/cvs.cgi/curl/lib/nss.c?r1=1.53&r2=1.59 (built as curl-7.19.6-12.fc13)While doing review of the patch, I spotted some nasty things in computing timeouts within Curl_nss_recv() and Curl_nss_send(). I wonder how this is supposed to work.The timeout value is ignored in non-blocking mode by NSPR.If I understand, you are fine with dropping the timeout computation at all, right?Kamil
No, that is needed to ensure it works the same way cross-platform. It is an NSPR-ism.
rob
smime.p7s
Description: S/MIME Cryptographic Signature
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
