> From: Daniel Stenberg <[email protected]> > To: libcurl development <[email protected]> > Date: Thu, 15 Oct 2009 23:41:05 +0200 (CEST) > Subject: Re: Patch to add support for ENG certificate type > On Thu, 15 Oct 2009, Camille Moncelier wrote: > >> This patch adds support for the file type SSL_FILETYPE_ENGINE for the client >> certificate. > > Thanks for your efforts to helping out and improving libcurl! > Thanks for your reply.
> > So what's the word about the "XXXX still needs some work" ? > To be honest it's just the result of a copy/paste from some code below. (SSL_FILETYPE_ENGINE for privatekey) > > And it does use // comments which we don't like here. > I changed the comment style. > > And commenting out code is not nice, we either leave it, > we make it conditional on some preprocessor magic or we remove it. > I commented the code to explain why I removed it, I deleted theses lines in the new patch. (or do you prefer a "#if 0" "#endif" ?) Camille Moncelier http://devlife.org/
curl-7.19.6-ssl-client-cert-engine-support-cleanup.patch
Description: Binary data
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
