2010/1/13, Kamil Dudka wrote: > On Wednesday 13 of January 2010 20:47:26 Yang Tse wrote: > > -AC_DEFUN([CURL_EXPORT_PCDIR], [ > > - if test -n "$1"; then > > +AC_DEFUN([CURL_EXPORT_PCDIR], > > + [if test -n "$1"; then > > > > Would prevent linefeed following opening backtick. > > Wait, that's intentionally :-) > > I just wanted the 'if' statement to really look as 'if' statement. > > Do your really prefer this... > > SSL_LDFLAGS=`if test -n "$OPENSSL_PCDIR"; then > PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR" > export PKG_CONFIG_LIBDIR > fi > $PKGCONFIG --libs-only-L openssl 2>/dev/null` > [...] > ... over this? > > SSL_LDFLAGS=` > if test -n "$OPENSSL_PCDIR"; then > PKG_CONFIG_LIBDIR="$OPENSSL_PCDIR" > export PKG_CONFIG_LIBDIR > fi > $PKGCONFIG --libs-only-L openssl 2>/dev/null` > [...]
Actually none of them, didn't want to be too picky and only expressed my concerns partially. But since it seems your fully interested in them... I'll say that my preference would be anything that generates the appropriate shell code in such a way the shell sees no linefeed at all (obviously this also excludes blank lines)between the opening and closing backticks. In order to achieve this while still allowing human readability the shell semicolon and backslash come handy. Of the two you options above the first one would be closer to my actual preference. Cheers -- -=[Yang]=- ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
