On Tue, 12 Jan 2010, Chris Conroy wrote:
Updated patch is ready for review.
I've read the code a bit more now and I have a few follow-up comments: * All the *_getsock() functions in the struct Curl_handler are set to ZERO_NULL in rtsp.c. This will effectively prevent RTSP from being a nice multi interface citizen. I suggest you try writing a multi interface using test app and make some adaptions to get that working too! * /* Increment the CSeq on success */ The comment says so at line 467 in lib/rtsp.c, but the incrementation is done disregarding if the previous function were successful or not! Is the comment or the code wrong? * 'data->state.rtsp_next_server_CSeq' seems not to be really used anywhere but yet you provide a function to extract its value. It looks like the implementation isn't complete? -- / daniel.haxx.se ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
