> > Okay, here we go. This is gopher for cURL round 2:
> 
> Thanks a lot for your contribution! I've just merged your patches with these 
> additional changes by me:
> 
> * converted the tests to instead use the HTTP server (with a --gopher
>    switch) to make them work better
> 
> * prevented a busy-loop
> 
> * fixed a memory leak
> 
> There's one (minor) problem left in the gopher code and I've added a big 
> comment blob in gopher.c about it:
> 
> The gopher_do() function sends the request in a loop-style which causes the 
> function to block until done. This is not fine for when the code is used by 
> the multi interface. Instead it should then send as much as possible in the 
> first shot and then continue sending the rest in a "doing" function.

Noted. I'll watch for this and I'll be happy to rewrite it if this turns
out to be a problem. Thanks for the accept and the review!

-- 
------------------------------------ personal: http://www.cameronkaiser.com/ --
  Cameron Kaiser * Floodgap Systems * www.floodgap.com * [email protected]
-- You do not have a soul. You are a soul. You have a body. -- C.S. Lewis -----
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to