On Sun, 30 Jan 2011, Amr Shahin wrote:
oops, please ignore the later patch and use the attached one, my bad ...
Thanks. But why do you break the tests on purpose every time? Testing if 1
equals 0 is not helping one bit and it annoys me a lot having to remove that
silliness. Aren't you running the tests the "real" way?
Also, a bit more on the nitpicking side, can I please ask you to follow our
code style even closer?
o No extra space after the start parenthesis in function calls and no extra
space before commas or before the closing parenthesis. We use this style:
this_function(a, b, c);
o No using tabs to indent the lines.
o When indenting the function arguments to a function call split up in
multiple lines, we have the subsequent lines get indented to the level of
the previous argument. Like:
fail_unless(llist->head == NULL,
"llist head is not NULL while the llist is empty");
... it'll make the process even smoother for us when receiving your patches!
--
/ daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
