Hi All, I've finally had some free time so I have made changes to include both httponly= and secure= as accepted parameters. I have attached the relevant patches. I would be grateful if they could be reviewed for errors or possible omissions. The patches also include changes to test31 to include an array of tests for both the secure and httponly options. If anyone can think of any other testcase that I am missing then please let me know so I can add it in and more importantly make sure the changes work in all cases.
Thanks, Rob On 5 July 2011 11:57, Rob Ward <[email protected]> wrote: > > > On 4 July 2011 22:35, Dan Fandrich <[email protected]> wrote: > >> On Mon, Jul 04, 2011 at 10:17:55PM +0100, Rob Ward wrote: >> > Do these cases seem sensible for that? >> > >> > Set-Cookie: httpandsec=myvalue ; domain=127.0.0.1; path=/p4/; httponly; >> secure >> > Set-Cookie: httpandsec2=myvalue2 ; domain=127.0.0.1; path=/p4/; >> httponly=; >> > secure >> > Set-Cookie: httpandsec3=myvalue3 ; domain=127.0.0.1; path=/p4/; >> httponly; >> > secure= >> > Set-Cookie: httpandsec4=myvalue4 ; domain=127.0.0.1; path=/p4/; >> httponly=; >> > secure= >> >> One where secure comes before httponly would be good to have as well. >> >> >>> Dan >> ------------------------------------------------------------------- >> List admin: http://cool.haxx.se/list/listinfo/curl-library >> Etiquette: http://curl.haxx.se/mail/etiquette.html >> > > > Something along the lines of seem suitable: > > Set-Cookie: httpandsec5=myvalue3 ; domain=127.0.0.1; path=/p4/; > secure; httponly= > Set-Cookie: httpandsec6=myvalue4 ; domain=127.0.0.1; path=/p4/; > secure=; httponly= > Set-Cookie: httpandsec7=myvalue3 ; domain=127.0.0.1; path=/p4/; > secure; httponly > Set-Cookie: httpandsec8=myvalue4 ; domain=127.0.0.1; path=/p4/; > secure=; httponly > Rob > > > -- > ------------------------------ > > Rob Ward > www.rob-ward.co.uk > -- ------------------------------ Rob Ward www.rob-ward.co.uk
cookie_secure.tar.gz
Description: GNU Zip compressed data
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
