On Thu, 22 Dec 2011, ElliƩ Computing Open Source Program wrote:

here are two small fixes for SSH:

Thanks a lot! It would be even more helpful if you would commit them with a proper commit message and then generate them with 'git format-patch' or send them with with 'git send-email' etc.

Now I'm left curious about one of the patches and I'm left to figure out what to do with your name as it seems unlikely that what's in your From: is what you're actually called...

1. QUOTE mkdir  should honor the option CURLOPT_NEW_DIRECTORY_PERMS

This seems clear. I'll apply and push.

2. Links should have PATH_MAX room (not 80 chars)

-          sshc->readdir_totalLen = 80 + sshc->readdir_currLen;
+          sshc->readdir_totalLen = PATH_MAX + sshc->readdir_currLen;

Why? Please elaborate and explain why it needs such a large buffer there.

--

 / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to