On 04/03/2012 11:27 AM, Daniel Stenberg wrote:
Yes, I think it is a bug and yes we would accept a patch!
Please find attached. -lijo
>From de7a5480f4207530f363cdcaaf8261e50cd2810f Mon Sep 17 00:00:00 2001 From: Lijo Antony <[email protected]> Date: Tue, 3 Apr 2012 02:45:25 +0400 Subject: [PATCH] connect.c: return changed to CURLE_COULDNT_CONNECT when opensocket fails Curl_socket returns CURLE_COULDNT_CONNECT when the opensocket callback returns CURL_SOCKET_BAD. Previous return value CURLE_FAILED_INIT conveys incorrect information to the user. --- lib/connect.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/connect.c b/lib/connect.c index 38f68b4..2d59229 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -1228,7 +1228,7 @@ CURLcode Curl_socket(struct connectdata *conn, if(*sockfd == CURL_SOCKET_BAD) /* no socket, no connection */ - return CURLE_FAILED_INIT; + return CURLE_COULDNT_CONNECT; #if defined(ENABLE_IPV6) && defined(HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID) if(conn->scope && (addr->family == AF_INET6)) { -- 1.7.5.4
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
