On Thu, 24 Jan 2013, Cedric Bosdonnat wrote:
I wrote a small patch to read Windows IE manual proxy settings and use them
(as curl already does with http_proxy and friends). I'll try to find some
time to enhance this patch to also read the automatic proxy configuration
for Windows.
Thanks!
My first impressions:
1 - you don't follow our code style, run lib/checksrc.pl and you'll find many
errors (tabs, spaces, line lengths)
2 - why did you move no_proxy out from the #ifdef? it will cause warnings on
proxy-disabled builds!
3 - you disable the old way of finding proxies on windows. Even if that might
not be the most popular way of providing proxy info (on windows), we can't
blindly assume that the numbers of users of that concept is zero. API
stability is one of the primary rules we live by.
4 - there's no documentation included for this functionality
Does this change which oldest possible Windows version libcurl can run on?
--
/ daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
