I was also wondering if there was some guidelines for naming #defines/constants in cURL. It seems that there is not one convention, e.g. I can see CURLOPT_PROGRESSDATA (words bunched together) as well as CURLOPT_LOW_SPEED_LIMIT. Is one style more current than another? I went for the second style.
YA ––– Learn about GPT services and architectures on Confluence. <http://confluence/display/GPT/GPT+Architecture> On 2/1/13 2:57 PM, "Yves Arrouye" <[email protected]> wrote: >Great. I can add documentation. > >One of the things I wanted feedback on was my choice of adding a struct >curl_oauth2_token and picking that as the value for the CURL_OAUTH2_TOKEN >option. I believe that it's the right thing because one could get a token >from any source, e.g. a file or direct response from an OAuth 2.0 token >endpoint (in which case one can parse that through another curl function >from lib/oauth2.c, which I may need to document similarly), or from a >database, etc. That also means that someone providing language bindings on >top of libcurl will have to expose that structure, though, but I still >think it's the right choice. > >I have a fork of curl on ExpediaInc's Github account, so that won't be a >problem and I try to keep current and rebase regularly so that it'll be >easy to pull from there. > >YA > > >Learn about GPT services and architectures on Confluence. ><http://confluence/display/GPT/GPT+Architecture> > > > > > >On 2/1/13 2:19 PM, "Guenter" <[email protected]> wrote: > >>Hi, >>Am 01.02.2013 18:49, schrieb Yves Arrouye: >>> I'll look at the test infrastructure. RE; docs on how to use it with >>> libcurl, where would that go? I've made it so that curl --libcurl will >>> produce decent examples, e.g.: >>thats great! >>> Are you talking about other examples in the docs/examples directory or >>> pure documentation, and where? >>no; sure if you create such a basic sample that wouldnt hurt, but what >>Daniel meant is that at least the new options like CURLOPT_OAUTH2_TOKEN >>must be documented; I guess this one f.e. as part of curl_easy_setopt(): >>http://curl.haxx.se/libcurl/c/curl_easy_setopt.html >>you can find all docu in the docu folder in git: >>https://github.com/bagder/curl >>if you have no experience with GIT then you can also just download a >>current tarball of all files in the repository (see the ZIP button), and >>work from there ... >> >>HTH, Gün. >> >> >> >> >>------------------------------------------------------------------- >>List admin: http://cool.haxx.se/list/listinfo/curl-library >>Etiquette: http://curl.haxx.se/mail/etiquette.html > > >------------------------------------------------------------------- >List admin: http://cool.haxx.se/list/listinfo/curl-library >Etiquette: http://curl.haxx.se/mail/etiquette.html ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
