This patch looks pretty good to me.
Regarding design mistakes, is there a good reason to also need to specify not
to disable progress? (noprogress = 0)
Why not imply it when specifying a callback?
Regarding unknown values, since we're switching to off_t, and off_t is signed,
there is no sane meaning to its negative values. We just transfered -4225
bytes? Perhaps <0 can signify unknown, and 0 only means 0.
-Nach
________________________________
From: Daniel Stenberg <[email protected]>
To: libcurl hacking <[email protected]>
Sent: Saturday, June 15, 2013 4:05 PM
Subject: A new callback function: XFERINFO ?
Hi friends,
It has been discussed so many times I decided to just make it. Attached here
is my first take on a new progress callback that doesn't use any double
(floating point) variable types. They were always a bad design choice that
have just been following along since the age of dawn.
We're in a feature freeze for another week so this is shown here to attract
your feedback and comments. What do you miss in the current callback and is
there any other design mistakes with the former one that we can fix while at
it?
For example, we can perhaps fix that annoying thing that we set unknown values
to 0 instead of signalling it a really nice way... (as 0 can also mean that it
is actually known to be 0!)
Thoughts?
--
/ daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
