curl.h should also include <sys/select.h> on OpenBSD to reliably
pull in select().  Typically, including <sys/time.h> will be enough,
but not if strict standards-compliance is requested (e.g. by defining
_XOPEN_SOURCE).

I think the FreeBSD version check is also dubious.  It's true that
FreeBSD 8.0+ pulls in <sys/select.h> from <sys/time.h>, so explicitly
including select.h isn't _strictly_ necessary, but again, this means
relying on a compatibility fallback.  <sys/select.h> is the documented
way to get select() on FreeBSD.

--- include/curl/curl.h.orig    Fri Sep 27 10:57:00 2013
+++ include/curl/curl.h Wed Dec  4 14:22:58 2013
@@ -69,7 +69,7 @@
    require it! */
 #if defined(_AIX) || defined(__NOVELL_LIBC__) || defined(__NetBSD__) || \
     defined(__minix) || defined(__SYMBIAN32__) || defined(__INTEGRITY) || \
-    defined(ANDROID) || defined(__ANDROID__) || \
+    defined(ANDROID) || defined(__ANDROID__) || defined(__OpenBSD__) || \
    (defined(__FreeBSD_version) && (__FreeBSD_version < 800000))
 #include <sys/select.h>
 #endif
-- 
Christian "naddy" Weisgerber                          [email protected]
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to