On Mon, 3 Feb 2014, Martín Germán Duarte wrote:
I made a patch to libcurl 7.3.1. This patch deals with the 401 Unauthorized
message in the RTSP negotiation, this message is not part of the RTSP
standard, but several IP cameras and RTSP servers need authentication to
work properly.
I have attached the readme.patch and the curl.patch
Thanks a lot for your contribution, but I have several problems with this
patch that we need to work on:
1 - why assign 'want = 2'? we have defines for all the auth values!
2 - why are you hardcoding that the request wants Digest auth there at all?
3 - Have you ran the test suite successfully with your patch applied? It
failed already on test 67 when I tried it.
4 - Is 401/407 responses for RTSP really defined to never have a body? And if
they are, do you really need the special treatment in the code then since
they won't get more data anyway? The *stop_reading assignment seems very
suspicious to me.
5 - Have you tried to add a test case for this in the curl test suite? RTSP
being so very similar to HTTP can most probably just use the HTTP test
server.
--
/ daniel.haxx.se-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
