On Wed, May 21, 2014 at 07:55:26PM -0700, Fabian Frank wrote: > Any other concerns or do you guys think we can merge this?
You still missed the extra const. It should be: +static const char* const protocols[] = ... You can also eliminate a #ifdef block by moving the definition of this into the existing #ifdef block where it's being used. +#ifdef HAS_ALPN + const char* next_protocol; +#endif And the same with this one. The fewer #ifdef blocks, the easier to read. >>> Dan ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
