Fabian Keil <[email protected]> wrote: > Dan Fandrich <[email protected]> wrote: > > > On Sun, Jul 27, 2014 at 01:32:51PM +0200, Fabian Keil wrote: > > > Dan Fandrich <[email protected]> wrote: > > > > On Fri, Jul 04, 2014 at 03:38:39PM +0200, Fabian Keil wrote: > > > > > > > > > Subject: [PATCH 1/6] Allow to overwrite $TESTDIR through the > > > > > environment > > > > > > > > This one seems like it could be useful. I would prefer that the > > > > environment variable be less generic; something with a CURL prefix > > > > would be better. > > > > > > Agreed. Attached is an updated version that uses CURL_TESTDIR instead. > > > Any other name is fine with me, too. > > > > After thinking about this one, it seems that there's no reason to use a > > magic environment variable for this, but rather a normal command-line > > option. Do you see a reason this couldn't be implemented that way? > > I have no objections to using a dedicated command-line option > for this. My main reason for not doing it was that the related > $srcdir is set through the environment as well. > > However, I also think that runtests.pl has lots of internal variables > one might want to change in certain situations, so maybe instead of adding > a dedicated option for all of them, there should be an option to overwrite > any internal variable (or only the ones on a white list). > > Such an option could also obsolete my patch that adds an -H option > to change the "IPv4 host IP address": > > ./runtests.pl -o TESTDIR=$privoxy_curl_test_dir -o HOSTIP=10.0.0.1 ...
Any thoughts about this? I'd really like to get the patches (or variations thereof) into the next curl release. Fabian
signature.asc
Description: PGP signature
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
