On Wed, 5 Nov 2014, Peter Wu wrote:

C has a default type of int and that test has worked on a fairly large amount of compilers and systems already... I assume you meant that it too failed with -Werror in CFLAGS?

Yes, it failed due to -Werror. A sane compiler should not break on this change.

In the world of legacy *nix systems there's a lot of IN-sanity so requiring a sane compiler is not for us! =)

I'm not saying this change actually *will* break anything, but I am cautios and hence me asking.

From a quick look, the tests are not built with -Werror though. Is that correct?

Yes it seems so, but I don't think it is on purpose. Or at least I can't think of any drawback to use -Werror there.

--

 / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to