On Fri, 7 Nov 2014, Brad King wrote: > Here is a patch series to fix it.
Many thanks for your efforts on this - it is much appreciate especially as our cmake builds have lacked in functionality for quite a while now. I'm sure Daniel will review this along with Peter's recent changes however I wanted to provide some very, very minor feedback... > Revert commit curl-7_39_0~160 (Cmake: Avoid cycle directory dependencies, > 2014-08-22) and add a comment explaining the purpose of the original code. I would recommend referencing the original commit in commit comments via a shortened version of the SHA-1 commit ID (I find that 9 or 10 characters are sufficient) so that tools can hyperlink to it as well as making a human search easier. As such the above could be: Revert commit 2257deb502 and add a comment explaining the purpose of the original code. Many thanks again Regards Steve ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
