This was my fault, but when enabling debug output the certificate status message is not aligned with the other SSL messages and it looks bad, e.g:
> STATE: SENDPROTOCONNECT => PROTOCONNECT handle 0x12618d8; line 1216 > (connection #0) > * server certificate verification OK > * SSL server certificate status verification OK > * common name: www.ghedini.me (matched) > * server certificate expiration date OK > * server certificate activation date OK > * certificate public key: RSA After the patch it's like this: > * STATE: SENDPROTOCONNECT => PROTOCONNECT handle 0x1f698d8; line 1216 > (connection #0) > * server certificate verification OK > * server certificate status verification OK > * common name: www.ghedini.me (matched) > * server certificate expiration date OK > * server certificate activation date OK > * certificate public key: RSA Cheers
From 54fee819a00b4ac36d05913cfb907ba598fe936d Mon Sep 17 00:00:00 2001 From: Alessandro Ghedini <[email protected]> Date: Mon, 9 Mar 2015 23:44:22 +0100 Subject: [PATCH] gtls: correctly align certificate status verification messages --- lib/vtls/gtls.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/vtls/gtls.c b/lib/vtls/gtls.c index 05aef19..19c659f 100644 --- a/lib/vtls/gtls.c +++ b/lib/vtls/gtls.c @@ -840,17 +840,17 @@ gtls_connect_step3(struct connectdata *conn, if(data->set.ssl.verifystatus) { if(gnutls_ocsp_status_request_is_checked(session, 0) == 0) { if(verify_status & GNUTLS_CERT_REVOKED) - failf(data, "SSL server certificate was REVOKED\n"); + infof(data, "\t server certificate was REVOKED\n"); else - failf(data, "SSL server certificate status verification FAILED"); + infof(data, "\t server certificate status verification FAILED\n"); return CURLE_SSL_INVALIDCERTSTATUS; } else - infof(data, "SSL server certificate status verification OK\n"); + infof(data, "\t server certificate status verification OK\n"); } else - infof(data, "SSL server certificate status verification SKIPPED\n"); + infof(data, "\t server certificate status verification SKIPPED\n"); #endif /* initialize an X.509 certificate structure. */ -- 2.1.4
signature.asc
Description: Digital signature
------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
