> -----Ursprüngliche Nachricht----- > Von: curl-library [mailto:[email protected]] Im Auftrag von > Daniel Stenberg > Gesendet: Dienstag, 17. März 2015 16:25 > An: libcurl development > Betreff: Re: dns cache doesn't refresh entries while they are in use > > On Tue, 17 Mar 2015, Stefan Bühler wrote: > > > It would be nice to get feedback for this specific commit, and maybe > > for the others as well. > > Please run lib/checksrc.pl on the code after your changes and correct the > warnings. There are a few style nits.
You are lucky I get paid to do this :P I updated the patches, and fixed a bug (CURLOPT_RESOLVE needs to release the reference from the cache insertion). > Have you given any thoughts on if it is possible to add any unit tests that > verify this functionality? You'd need to control/implement a (stub) DNS resolver, and tell the curl resolver to use it. Best regards, Stefan Bühler ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
