On Thu, May 21, 2015 at 02:11:02PM +0200, Daniel Stenberg wrote: > On Thu, 21 May 2015, Daniel Stenberg wrote: > > >Right, and that's a combination we really should not allow. It is > >a bug. CURLOPT_HTTPPROXYTUNNEL implies a HTTP proxy, and socks5 > >means no HTTPTUNNEL... > > ... so I say we apply this patch so that setting either proxy type > or proxytunnel make sure the other option is sensible. > > You agree? >
Isn't it also possible for proxytype to be derived from CURLOPT_PROXY by parse_proxy()? ie. I could set CURLOPT_PROXY "socks5://<addr>:<port>" and still end up with tunnel_proxy set but not httpproxy? BTW the comment above parse_proxy() should have the bit about it freeing the argument removed. ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html
