On Mon, 17 Aug 2015, Michael König wrote:

When trying to use libcurl with some embedded TFTP server implementation i ran into trouble, due to faulty TFTP option handling.

Thanks!

I'm generally a bit cautious about adding work-around for specific server flaws unless they're in really wide use. Do you know anything about what software/version this particular server is or how commonly it is used?

In this case the server reported a transfer size of 0, instead of just omitting the size, because it was unknown. This caused libcurl to do exactly nothing, which was correct, but not what i hoped for. The server behaved as intended, when the TFTP options were missing from the read request. To enable libcurl to do something like this i added a new option "CURLOPT_TFTP_NO_OPTIONS" to curl_easy_setopt(), which when set to 1 omits any TFTP options from read or write requests.

Based on my understanding of your patch, this only prevents libcurl from sending any options. Given your explanation above, wasn't the problem that the server sent an unexpected option + value ?

--

 / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html

Reply via email to