On Wed, 30 Sep 2015, Tim Ruehsen wrote:
Okay, back on track!
I added test1136 (with PSL as keyword - not sure if it must be lower- or
uppercase).
It looks like all the code assumes uppercase.
It works when libpsl is compiled/linked, else it doesn't.
I did a 'runtests.pl 1136', but did not have the time to run a 'make check' to
see if the test is skipped when compiled without libpsl.
Two nits and a question.
1. try 'make checksrc' and it'll point out a few style nits (or use
./configure --enable-debug and then ordinary make invokes will do that for
you)
2. there are fprintf() calls left in the code and commented out infof() calls
Q: This uses a built-in PSL database within libpsl, right? Is there any
support or plans for externally providing an updated PSL? I'm thinking perhaps
someone who uses libcurl with PSL in systems that have a life time expectensy
of some time may want to have means to update the db rather than to update the
lib? (it doesn't really concern this patch, its just a general question about
libpsl)
--
/ daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
