Hi,

According to https://github.com/madler/zlib/blob/master/win32/README-WIN32.txt,
and from building zlib from source on Windows, the names of the
libraries in zlib are "zlib1.dll" and "zdll.lib" for DLL and
"zlib.lib" for static.

However, in winbuild/MakeBuild.vc, the name used when WITH_ZLIB=dll is
"zlib.lib" and for WITH_ZLIB=static is "zlib_a.lib"

See winbuild/MakeBuild.vc  line 184:

!IF "$(WITH_ZLIB)"=="dll"
ZLIB_LIBS = zlib.lib
USE_ZLIB  = true
ZLIB = dll
!ELSEIF "$(WITH_ZLIB)"=="static"
ZLIB_LIBS = zlib_a.lib
USE_ZLIB = true
ZLIB = static
!ENDIF

These don't match what I believe zlib provides - so what am I missing?

If it's nothing, then I'm happy to provide a PR that either:
   1, Uses the library names that zlib documents, or
   2, Supports both existing names and the documented zlib names by
checking for existence of files in DEVEL_LIB similar to the checks for
OpenSSL.


Does this seem reasonable?


-- 
Richard
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.haxx.se/mail/etiquette.html

Reply via email to