On Fri, 20 Jul 2018, Daniel Jeliński wrote:
2018-07-19 18:45 GMT+02:00 Daniel Stenberg <[email protected]>:
https://github.com/curl/curl/pull/2762
Thank you! I see that the test builds succeeded. What's next?
I would prefer to get some additional thumbs up or down from other Windows
developers. The change *seems* innocent and simply enough to incorporate like
this, but it would be cool to get this tested and vetted by a few more first.
So in its current form the patch won't help MinGW. Other MinGW projects
worked around that problem by creating that #define in their own code
I wouldn't mind doing that for the sake of increased performance for those who
build curl with mingw.
the next best available option for MinGW users is to determine optimal
buffer size using trial and error, or just set it as large as possible.
Should we put that in the documentation?
I personally think using a private define would be preferable to do
documenting something as "weird" and compiler and system specific as that...
But then I don't develop on Windows nor do I build with mingw!
--
/ daniel.haxx.se
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
