> > -#ifdef USE_WINSOCK
> > +#if defined(USE_WINSOCK) || \
> > +   !defined(SHUT_RD) && (defined(HAVE_SOCKET_H) ||
> > defined(HAVE_SYS_SOCKET_H))
> > #  define SHUT_RD   0x00
> > #  define SHUT_WR   0x01
> > #  define SHUT_RDWR 0x02
> 
> Isn't it better to just do #ifndef for each define? Like this:
> 
>    https://github.com/curl/curl/pull/6925

Thanks for the change.  The intent was to suggest an edit in
a manner that clearly communicated what was wrong.  It is
perfectly fine for the patch to look different than what
was proposed as it accomplishes the end goal.

Kevin R. Bulgrien
-------------------------------------------------------------------
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html

Reply via email to