Den lör 5 feb. 2022 kl 10:52 skrev Daniel Stenberg <dan...@haxx.se>:
> On Sat, 5 Feb 2022, Henrik Holst wrote: > > > The remaining 109 for google.com and hostmatch() requires a very > intrusive > > patch however since it would require to add a size_t to struct hostname > (aka > > add Howard Chu:s berval string) and that struct is used _alot_ (which > also > > means that there can be other winnings down the line besides the > certcheck > > since the hostname length is probably used a bit). > > I'm not convinced that's a change we want. We need to remember that these > are > "just" calls to strlen() and typically for very short strings. If we can't > measure a performance impact, we shouldn't do changes that make the code > hard to read or "unusual". > I hear what you say, however I don't know if adding a size_t hostlen to the hostname struct would make the code hard to read or unusual. Anyway, I will take a look at it first and then come back with more info and you can all decide then if the proposed changes are too hard to read or unusual, I have no problem doing some some work that in the end will be rejected. /HH > > -- > > / daniel.haxx.se > | Commercial curl support up to 24x7 is available! > | Private help, bug fixes, support, ports, new features > | https://curl.se/support.html >
-- Unsubscribe: https://lists.haxx.se/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
