On 22/06/2013 3:44, Izumi Tsutsui wrote:
For readability, it's better to use an explicit temporary variable,
to keep o->len in the target byteorder:
---
                        len_tmp = encode_rfc1035(hostname, p + 1);
                        if (len_tmp == 0)
                                *p = 0x04;
                        o->len = htons(len_tmp + 1);
---

BTW, a magic "0x04" seems also awful for readers...

Both these issues should now be fixed.

Thanks
Roy

Reply via email to