On Mon, Mar 10, 2014 at 5:04 PM, Ryota Ozaki <[email protected]> wrote: > Hi, > > I've updated my patch. > > https://gist.github.com/ozaki-r/8535846 > http://www.netbsd.org/~ozaki-r/dtrace-arm.patch > > The patch now consists of a few files: > > $ diffstat dtrace-arm.patch > external/cddl/osnet/dev/dtrace/arm/dtrace_asm.S | 13 > external/cddl/osnet/dev/dtrace/arm/dtrace_isa.c | 11 > external/cddl/osnet/dev/fbt/fbt.c | 576 > ++++++++++++++++++++++- > external/cddl/osnet/dist/uts/common/sys/dtrace.h | 14 > sys/arch/arm/arm/undefined.c | 49 + > sys/arch/arm/include/trap.h | 8 > 6 files changed, 670 insertions(+), 4 deletions(-) > > undefined.c and trap.h are already reviewed by matt > and may be ready to merge. (two global variables for > dtrace/fbt modules has been added to undefined.c > since then, although I think it's not a big deal.) > Can I commit them? (or by matt is better?) > > dtrace.h just defines some variables and dtrace_asm.S > just hooks up a callback for fbt, which are trivial. > I think these files can be committed once other files > are committed. > > fbt.c is the biggest change in this porting work. It explores > probe points of functions in the kernel, replaces instructions > of the probe points, and emulates the replaced instructions. > I want someone to take a look at it before merging. > > The change of dtrace_isa.c is not big and important, but > a bit dirty. It copies macros (yes, FR_* ones) from another > place to make it buildable. I know the workaround is not > awesome, but it makes dtrace work anyway. > > Any comments are welcome :-)
I will commit the patch during AsiaBSDCon 2014 if there is no objection :) Regards, ozaki-r
