A big +1 for wider use of UINTx_C(). Same for *reg.h headers. On Friday, March 21, 2014, Joerg Sonnenberger <[email protected]> wrote:
> On Fri, Mar 21, 2014 at 08:23:54AM +0000, David Laight wrote: > > On Thu, Mar 20, 2014 at 06:27:55PM -0400, David H. Gutteridge wrote: > > > On Tue, 18 Mar 2014 at 19:17:01, Taylor R Campbell wrote: > > > From looking at the code, it's clear you're already aware of the > > > issue, given your "XXX" notation. > > > > > > error = bus_space_alloc(bst, start, 0xffffffffffffffffULL /* XXX */, > > > size, align, 0, 0, &resource->start, &resource->r_bsh); > > > > > > I don't know if it's the preferred NetBSD way to handle this, but I'd > > > be inclined to add a macro that defines that literal value differently > > > depending on whether it's an amd64/i386 PAE build or a plain i386 > > > build. > > > > ((uint64_t)0xfffffffful << 32 | 0xffffffff) > > works for both. > > UINT64_C(0xffffffffffffffff) > > Joerg >
