On Mar 9, 12:16pm, s...@stix.id.au (Paul Ripke) wrote: -- Subject: Re: Fatal page fault in cbq_enqueue()
| > > Index: altq_classq.h | > > =================================================================== | > > RCS file: /cvsroot/src/sys/altq/altq_classq.h,v | > > retrieving revision 1.7 | > > diff -u -u -r1.7 altq_classq.h | > > --- altq_classq.h 12 Oct 2006 19:59:08 -0000 1.7 | > > +++ altq_classq.h 27 Jan 2017 18:10:12 -0000 | > > @@ -108,9 +108,9 @@ | > > { | > > struct mbuf *m, *m0; | > > | > > - if ((m = qtail(q)) == NULL) | > > + if ((m = qtail(q)) == NULL || (m0 = m->m_nextpkt) == NULL) | > > return (NULL); | > > - if ((m0 = m->m_nextpkt) != m) | > > + if (m0 != m) | > > m->m_nextpkt = m0->m_nextpkt; | > > else | > > qtail(q) = NULL; | > | > Indeed... Well, we'll see how it goes, I'm running with that now. I've | > had one crash since, so a couple of weeks might be enough to have some | > idea. | | Pity. Crashed elsewhere. I think there's a definite race in altq somewhere. So it took how many days? christos