Re: VirtualBox additions - small patch for 8.99.46

[Chavdar Ivanov]

He has done it already.

On Thu, 20 Jun 2019 at 09:10, <m...@netbsd.org> wrote:
>
> On Wed, Jun 19, 2019 at 06:55:06PM +0100, Chavdar Ivanov wrote:
> > --- 
> > /p/VirtualBox-6.0.8/src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG
> >        2019-06-19 19:48:40.880337377 +0100
> > +++ 
> > /p/VirtualBox-6.0.8/src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c
> >  2019-06-19 19:48:51.063261324 +0100
> > @@ -1011,7 +1011,7 @@
> >
> >              error = do_sys_mknod(curlwp, "/dev/vboxguest",
> >                                   0666|S_IFCHR, makedev(cmajor, 0),
> > -                                 &retval, UIO_SYSSPACE);
> > +                                 UIO_SYSSPACE);
> >              if (error == EEXIST)
> >                  error = 0;
> >              break;
> >
> > Needed after 8.99.46.
> >
> > --
> > ----
>
> Probably the right thing is to wrap this by a version check from
> sys/param.h, so the old code can be used for netbsd-8 still.
>
> #if __NetBSD_Version__ >= 899004600
> One less arg
> #else
> existing code
> #endif
>
> But it's not our code, so I don't know whether anyone netbsd-side
> controls it (maybe uwe?).



-- 
----