Hi Robert,
On Tue, Dec 10, 2019 at 08:54:12AM +0700, Robert Elz wrote:
> Date: Tue, 10 Dec 2019 00:49:43 +0000 (UTC)
> From: NetBSD Test Fixture <brac...@netbsd.org>
> Message-ID: <157593898298.13655.3447375934086628...@babylon5.netbsd.org>
>
> | This is an automatically generated notice of a NetBSD-current/i386
> | build failure.
>
> |
> /tmp/bracket/build/2019.12.09.21.08.56-i386/src/sys/kern/kern_mutex.c:836:7:
> error: implicit declaration of function 'mutex_oncpu'; did you mean
> 'mutex_dump'? [-Werror=implicit-function-declaration]
> | rv = mutex_oncpu(MUTEX_OWNER(mtx->mtx_owner));
> | ^~~~~~~~~~~
>
>
> To answer gcc, obviously not ...
>
> The problem is that mutex_oncpu() is currently only defined with
> MULTIPROCESSOR and Xen Dom0 kernels are not MULTIPROCESSOR capable.
>
> Andrew, can you either fix mutex_owner_running() to not use mutex_oncpu()
> in the !MULTIPROCESSOR case, or supply a version of mutex_oncpu() that
> is appropriate there.
>
> My thinking was something like
>
> #else /* MULTIPROCESSOR */
> static /*inline?*/ bool
> mutex_oncpu(uintptr_t owner)
> {
> return MUTEX_OWNED(owner);
> }
>
>
> inserted just before
> #endif /* MULTIPROCESSOR */
>
> in the obvious place, but that is probably much too simple ?
Done, thank you. Too much preprocessor goop in that file I'll take a look
some time.
Andrew
