On Wed, Jan 08, 2020 at 04:04:31PM +0100, Adam wrote: > > Index: pkgsrc/lang/nodejs/patches/patch-deps_v8_src_zone_zone.h > > diff -u /dev/null > > pkgsrc/lang/nodejs/patches/patch-deps_v8_src_zone_zone.h:1.1 > > --- /dev/null Mon Jan 6 23:06:44 2020 > > +++ pkgsrc/lang/nodejs/patches/patch-deps_v8_src_zone_zone.h Mon Jan > > 6 23:06:44 2020 > > @@ -0,0 +1,18 @@ > > +$NetBSD: patch-deps_v8_src_zone_zone.h,v 1.1 2020/01/06 23:06:44 tnn Exp $ > > + > > +Work around type issue in NetBSD's copy of libc++ headers. > > +Believed to be fixed in upstream libc++ already. > > +https://github.com/nodejs/node/issues/30638 > > + > > +--- deps/v8/src/zone/zone.h.orig 2019-12-18 17:26:45.000000000 +0000 > > ++++ deps/v8/src/zone/zone.h > > +@@ -141,6 +141,9 @@ class ZoneObject { > > + public: > > + // Allocate a new ZoneObject of 'size' bytes in the Zone. > > + void* operator new(size_t size, Zone* zone) { return zone->New(size); } > > ++#if defined(__NetBSD__) && defined(__clang__) > > ++ void* operator new(size_t size, void* zone) { return > > ((Zone*)zone)->New(size); } > > ++#endif > > + > > + // Ideally, the delete operator should be private instead of > > + // public, but unfortunately the compiler sometimes synthesizes > > Clearly, we need newer libc++ in the tree. Can someone, please, do the update?
Clearly, the update would have happened already if it was trivial. > Also, it would be much better to have its includes in /usr/include/c++/v1 > (not in /usr/include/c++). No, it wouldn't be. It literally improves nothing. Joerg
