> > (1) out of bounds problem in xserver/hw/xfree86/modes/xf86Crtc.h > > > > OpenBSD/luna88k maintainer (Kenji Aoyama) reported the following fix > > was neceesary for non-XFree86 driver based dumb server (on luna88k etc.): > > https://gist.github.com/ao-kenji/afb0ea5b6dca04975161f84ab41ba32b > > https://gist.github.com/ao-kenji/b0fd6b876605ba1b2b43309233566153 > > > > https://cvsweb.openbsd.org/cgi-bin/cvsweb/xenocara/xserver/hw/xfree86/modes/xf86Crtc.h#rev1.16 > > I turns out that at least luna68k Xorg server (happens to?) works > without this change, but anyway upstream 1.22.x branch already > has this fix: > > https://gitlab.freedesktop.org/xorg/xserver/-/commit/75d70612888f18339703315549db781a22c0cb23 > > I wonder if we should pull this fix or not for our (1.)21.1.4 tree..
this looks simple enough to just do. > > (2) "-flipPixels" option removal > > > > "-flipPixels" option (that inverts black and white on 1bpp server) > > has been removed since 1.21. > > > > https://gitlab.freedesktop.org/xorg/xserver/-/commit/d1c00c859c6676fbb540420c9055788bc19cb18f > > > > As noted in the log the upstream authors claim > > "No supported driver supports 1bpp anymore, nor has in a very long time." > > > > Howeverwe we still have several working servers (xf86-video-wsfb based > > servers on mac68k and luna68k, monolithic servers for sun3 and x68) > > and at least there was a report that this option was mandatory on SE/30. > > So I would like to revert this change. > > It also turns out that the above changes also remove a menber from > ScrnInfoRec structure in hw/xfree86/common/xf86str.h and it breaks > ABIs of xf86-video-* drivers. > > However fortunately the removed member "Bool flipPixels" in the > SrcnInfoRec has not been used for -flipPixels options so we can > safely pull back -flipPixels support by reverting the changes > except xf86str.h. > > If there is no particular comments I would like to commit the > attached (reverting -flipPixels removal) patch. go for it. we have a few things reverted, we maybe should talk to upstream to have them either revert there or at least provide the removed features elsewhere. thanks. .mrg.
