Re: getmntinfo compatibility question

[Thomas Klausner]

On Fri, Feb 14, 2025 at 09:35:43AM +0100, Martin Husemann wrote:
> On Fri, Feb 14, 2025 at 09:22:54AM +0100, Thomas Klausner wrote:
> > Perhaps we need to add code like FreeBSD has (to rust libc):
> > https://github.com/rust-lang/libc/blob/2258bf0fb96767bcffbe3ed09b29a31ee54b549b/src/unix/bsd/freebsdlike/freebsd/mod.rs#L5340
> 
> Your rust binary calls __getvfsstat90 (according to ktrace),

Yes, but the compat layer calls a translate function.

see src/lib/libc/compat/sys/compat_statvfs.c:

int
__compat_statvfs(const char *path, struct statvfs90 *buf)
{
        struct statvfs sb;
        int error = __statvfs190(path, &sb, 0);
        if (error != -1)
                statvfs_to_statvfs90(&sb, buf);
        return error;
}

so you can't tell from the syscall level which struct I need.

Now I'm just unsure how to apply the patch to rust-libc because it
only applies to NetBSD 10, and I'm not sure what, if anything, is
needed on NetBSD 9.
 Thomas