On Mon, Apr 20, 2020 at 08:27:59PM -0000, Ryan Harper wrote: > Let me drop the logging bits
Thanks! > > diff --git a/tests/unittests/test_block_zfs.py > > b/tests/unittests/test_block_zfs.py > > index 3508d4b..2be7c41 100644 > > --- a/tests/unittests/test_block_zfs.py > > +++ b/tests/unittests/test_block_zfs.py > > @@ -425,6 +425,9 @@ class TestAssertZfsSupported(CiTestCase): > > def setUp(self): > > super(TestAssertZfsSupported, self).setUp() > > > > + def tearDown(self): > > + self.allowed_subp = False > > I think this is reasonable safe. It's off by default. The test-cases > that know they need it set it at the start of their test_*; this just > retains the default off unless you need it and I think help reduce the > scope of when subp is enabled. Yep, I think the case I was worried about isn't applicable here, so let's stick with this. -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
