Review: Needs Fixing Hi György,
I ran the CI on the wrong revision, my bad. We actually have some failures, see the full run log [1]. The errors are just linting issues: py3-pylint: curtin/block/clear_holders.py:170:80: E501 line too long (100 > 79 characters) curtin/block/mdadm.py:149:80: E501 line too long (89 > 79 characters) curtin/block/mdadm.py:163:80: E501 line too long (83 > 79 characters) curtin/block/mdadm.py:165:80: E501 line too long (89 > 79 characters) curtin/block/mdadm.py:362:1: E302 expected 2 blank lines, found 1 curtin/block/mdadm.py:519:80: E501 line too long (84 > 79 characters) curtin/block/mdadm.py:615:41: E703 statement ends with a semicolon curtin/block/mdadm.py:853:1: E302 expected 2 blank lines, found 1 curtin/commands/block_meta.py:1495:80: E501 line too long (88 > 79 characters) curtin/commands/block_meta.py:1509:21: E128 continuation line under-indented for visual indent tests/unittests/test_block_mdadm.py:274:80: E501 line too long (98 > 79 characters) tests/unittests/test_block_mdadm.py:277:1: E302 expected 2 blank lines, found 1 tests/unittests/test_block_mdadm.py:1340:1: E302 expected 2 blank lines, found 1 tests/unittests/test_clear_holders.py:268:29: E128 continuation line under-indented for visual indent tests/unittests/test_clear_holders.py:272:9: F841 local variable 'md_devs' is assigned to but never used tests/unittests/test_clear_holders.py:278:69: E231 missing whitespace after ':' tests/unittests/test_clear_holders.py:278:80: E501 line too long (85 > 79 characters) py3-pyflakes: tests/unittests/test_clear_holders.py:272: local variable 'md_devs' is assigned to but never used Please rebase your branch on master (mainly to pickup [2]), run `tox` and fix all the linting issues it will spot. In general I think the MP is in good shape, thanks for working on it! Paride [1] https://paste.ubuntu.com/p/s3zCszGCMy/ [2] https://git.launchpad.net/curtin/commit/?id=ac7d5e5c5f6b14fb9a1429594a4d28abe9448793 -- https://code.launchpad.net/~gyurco/curtin/+git/curtin/+merge/390307 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
