Review: Approve
One thought on an alternative solution, but this proposal and its testing LGTM
as-is.
Diff comments:
> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index 25910a0..cf6bc02 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -887,7 +887,9 @@ def partition_handler(info, storage_config):
> part_path = block.dev_path(
> block.partition_kname(disk_kname, partnumber))
> partition_verify_sfdisk(part_path, info)
> - LOG.debug('Partition %s already present, skipping create', part_path)
> + LOG.debug(
> + '%s partition %s already present, skipping create',
I wonder if having the determined part_path in the log is useful debugging
information that we're dropping here? (That could potentially be addressed by
indenting the existing logging statement and adding a different log message to
the other path.)
> + disk, partnumber)
> create_partition = False
>
> if create_partition:
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/396881
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
