Review: Needs Fixing Thanks for submitting a patch to curtin! The updated regex looks fine. Would you add a unittest?
tests/unittests/test_storage_config.py: You could copy and adapt test_disk_schema_accepts_nvme_eui or wwid into a test_disk_schema_accepts_nvme_uuid with the wwid:uuid. pattern from above. You can update your branch and push and this MP will update with your changes. See more details here: https://curtin.readthedocs.io/en/latest/topics/hacking.html#do-these-things-for-each-feature-or-bug -- https://code.launchpad.net/~ryan-p-norwood/curtin/+git/curtin/+merge/401624 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
