Right I think it makes sense that you should be able to feed curtin output 
straight back into curtin. If we are going to move away from that the extra 
keys that are not valid for curtin should be something very clearly different 
like "$devpath$" or something but I think that is still pretty ugly. I think 
you can change the schema to enforce that any unknown attributes have to match 
a regex (like starting with _ or something) and then document that they are 
ignored.

I agree that it's most curtinish to check the path values are correct if 
passed. But that just feels like makework (even though it would probably take 
less time than adding this comment). I should probably just do it.


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/429401
Your team curtin developers is requested to review the proposed merge of 
~mwhudson/curtin:FR-2656-attach-device-to-action into curtin:master.


-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to     : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to