Off that was a bit of a brain-o on my part. As Dan says, an integration test
would be nice.
Diff comments:
> diff --git a/curtin/commands/block_meta_v2.py
> b/curtin/commands/block_meta_v2.py
> index ae0b058..7939ba1 100644
> --- a/curtin/commands/block_meta_v2.py
> +++ b/curtin/commands/block_meta_v2.py
> @@ -26,6 +26,12 @@ from curtin.storage_config import (
> from curtin.udev import udevadm_settle
>
>
> +def to_utf8_hex_notation(string: str) -> str:
> + ''' Convert a unicode string into a UTF-8 representation using the \\x
> + notation. '''
> + return ''.join([f'\\x{c:02x}' for c in bytearray(string, 'utf-8')])
I would sort of prefer to not replace _all_ characters with the \x form. Like
things that pass bytes.isalnum should be OK to leave alone?
> +
> +
> @attr.s(auto_attribs=True)
> class PartTableEntry:
> # The order listed here matches the order sfdisk represents these fields
--
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/442225
Your team curtin developers is requested to review the proposed merge of
~ogayot/curtin:sfdisk-accept-utf8 into curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~curtin-dev
More help : https://help.launchpad.net/ListHelp
