Review: Needs Information
Diff comments: > diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py > index 0539c83..6a09277 100644 > --- a/curtin/commands/curthooks.py > +++ b/curtin/commands/curthooks.py > @@ -1953,7 +1972,13 @@ def builtin_curthooks(cfg, target, state): > if osfamily == DISTROS.debian: > # re-enable update_initramfs > enable_update_initramfs(cfg, target, machine) > - update_initramfs(target, all_kernels=True) > + if not (pathlib.Path(target) / 'usr/bin/dracut').exists(): > + update_initramfs(target, all_kernels=True) A few lines above is another update_initramfs() call, related to crypttab, would we see a similar crash there? I think at minimum we need to move this check for dracut into `update_initramfs()`, and later we might want to implement a divert setup for dracut for performance reasons. > + else: > + # For the NVMe/TCP POC, we don't have initramfs-tools anymore > + # at this point and dracut was not diverted, so no need to > + # re-run it. > + pass > elif osfamily == DISTROS.redhat: > redhat_update_initramfs(target, cfg) > -- https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/473058 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-dev More help : https://help.launchpad.net/ListHelp
